From: Stefan Agner <ste...@agner.ch>
Date: Sun, 16 Apr 2017 23:20:32 -0700
> The attribute declaration is typically before the definition. Move
> the __maybe_unused attribute declaration before the struct keyword.
>
> Signed-off-by: Stefan Agner <ste...@agner.ch>
Well, I see if just as often after the variable name too:
net/irda/iriap.c:static const char *const ias_charset_types[] __maybe_unused = {
net/irda/irlap.c:static const char *const lap_reasons[] __maybe_unused = {
net/irda/irlap_event.c:static const char *const irlap_event[] __maybe_unused = {
net/irda/irlmp_event.c:static const char *const irlmp_event[] __maybe_unused = {
Or after the struct:
drivers/net/phy/ste10Xp.c:static struct mdio_device_id __maybe_unused
ste10Xp_tbl[] = {
drivers/net/phy/teranetics.c:static struct mdio_device_id __maybe_unused
teranetics_tbl[] = {
drivers/net/phy/vitesse.c:static struct mdio_device_id __maybe_unused
vitesse_tbl[] = {
So unless we decide tree wide to do it in one order or another, such changes
are largely a waste of time.
Sorry I'm not applying this patch.
