On 12-04-17, 22:07, Thomas Gleixner wrote: > The access to the HBIRD_ESTAR_MODE register in the cpu frequency control > functions must happen on the target CPU. This is achieved by temporarily > setting the affinity of the calling user space thread to the requested CPU > and reset it to the original affinity afterwards. > > That's racy vs. CPU hotplug and concurrent affinity settings for that > thread resulting in code executing on the wrong CPU and overwriting the > new affinity setting. > > Replace it by a straight forward smp function call. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > Cc: Viresh Kumar <viresh.ku...@linaro.org> > Cc: linux...@vger.kernel.org > --- > drivers/cpufreq/sparc-us2e-cpufreq.c | 45 > ++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 24 deletions(-)
Acked-by: Viresh Kumar <viresh.ku...@linaro.org> -- viresh
