On Mon, 2017-04-03 at 14:15 +0200, Corentin Labbe wrote:
> This patch fix all style issue for braces and alignment
[]
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
[]
> @@ -255,9 +255,9 @@ static int hpet_open(struct inode *inode, struct file
> *file)
>
> for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp = hpetp->hp_next)
> for (i = 0; i < hpetp->hp_ntimer; i++)
> - if (hpetp->hp_dev[i].hd_flags & HPET_OPEN)
> + if (hpetp->hp_dev[i].hd_flags & HPET_OPEN) {
> continue;
> - else {
> + } else {
> devp = &hpetp->hp_dev[i];
> break;
> }
Perhaps this is clearer as:
for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp =
hpetp->hp_next) {
for (i = 0; i < hpetp->hp_ntimer; i++) {
if (!(hpetp->hp_dev[i].hd_flags & HPET_OPEN)) {
devp = &hpetp->hp_dev[i];
break;
}
}
}
> @@ -304,9 +304,9 @@ hpet_read(struct file *file, char __user *buf, size_t
> count, loff_t *ppos)
> devp->hd_irqdata = 0;
> spin_unlock_irq(&hpet_lock);
>
> - if (data)
> + if (data) {
> break;
> - else if (file->f_flags & O_NONBLOCK) {
> + } else if (file->f_flags & O_NONBLOCK) {
break; else is almost always better as break
and reduced indentation
