Hi Brian, On Sat, Mar 24, 2007 at 01:56:50AM -0700, Brian Braunstein wrote: > > Linus, > > According to Documentation/SubmittingPatches "bug fixes" or "obvious" > changes > should CCed to you, so this is why I have done this. >
IMHO these days patches got reviewed on LKML, then tested enough on the unstable -mm tree then it got added to mainline kernel. Subsystem maintaners can also add patches directly to mainline if they're trivial enough. > Note: This entire email can be found at > http://bristyle.com/share/patch-tuntap-hw_addr_handling.txt > I think No need for such two lines. everyone uses his favourite LKML archive. > Summary: > Fix tun/tap driver's handling of hw addresses. Specifically, ensure > that > when the tun.dev_addr field is set, the net_device.dev_addr field gets > set to the same value. > > Background: > The device hw address is stored in 2 places, in the tun.dev_addr field, > and of course the net_device struct's dev_addr field. It really > seems to > me that the tun.dev_addr field is redundant, and that anywhere it is > used Editor/mailer wrapping your lines badly ? > > --- linux-2.6.20.4-ORIG/drivers/net/tun.c 2007-03-23 > 12:52:51.000000000 -0700 > +++ linux-2.6.20.4/drivers/net/tun.c 2007-03-24 01:36:59.000000000 -0700 > @@ -18,6 +18,11 @@ Please reread SubmittingPatches to know the canonical patch format (missing Signed-off-by and others). > /* > * Changes: > * > + * Brian Braunstein <[EMAIL PROTECTED]> 2007/03/23 > + * Fixed hw address handling. Now net_device.dev_addr is kept > consistent [Remaing patch] Patch can't be applied or even read cause your mailer has mistakenly wrapped its lines. Regards, -- Ahmed S. Darwish http://darwish.07.googlepages.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
