On Tue, Mar 21, 2017 at 5:32 PM, Sebastian Reichel <s...@kernel.org> wrote:
> This adds a driver for the Nokia H4+ protocol, which is used
> at least on the Nokia N9, N900 & N950.
>
> Signed-off-by: Sebastian Reichel <s...@kernel.org>
> ---
> + btdev->wakeup_host = devm_gpiod_get(dev, "host-wakeup", GPIOD_IN);
> + if (IS_ERR(btdev->wakeup_host)) {
> + err = PTR_ERR(btdev->wakeup_host);
> + dev_err(dev, "could not get host wakeup gpio: %d", err);
> + return err;
> + }
> +
> + btdev->wake_irq = gpiod_to_irq(btdev->wakeup_host);
Missed this in the binding review, but generally, we make these
interrupts rather than gpios in the binding.
> +
> + err = devm_request_threaded_irq(dev, btdev->wake_irq, NULL,
> + wakeup_handler,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + "wakeup", btdev);
> + if (err) {
> + dev_err(dev, "could request wakeup irq: %d", err);
> + return err;
> + }
