Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu: > > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote: > > > > +++ b/tools/perf/util/annotate.c > > > > @@ -1443,7 +1443,7 @@ int symbol__disassemble(struct symbol *sym, > > > > struct map *map, const char *arch_na > > > > snprintf(command, sizeof(command), > > > > "%s %s%s --start-address=0x%016" PRIx64 > > > > " --stop-address=0x%016" PRIx64 > > > > - " -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand", > > > > + " -l -d %s %s -C %s 2>/dev/null|grep -v %s: |expand", > > > > Are you sure this works as you expect? I.e. both lines will have '%s:' > > > Yes, if we do, we can exactly the only below line without the side effect > > IMHO. > > yeah, because the .c is not there, ok gotcha, will get your new commit > log message, massage it a bit and apply the patch.
Nah, with all this in mind, the original message is good enough, sorry for the confusion with the .c and the space after ':' (that I removed, needless and potentially confusing, as we saw here). - Arnaldo
