Rusty,
On Thu, 22 Mar 2007 20:24:10 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-03-22 at 09:10 +0100, Sébastien Dugué wrote:
> > Why not take on the opportunity to rename boot_gt_table to boot_gtd,
> > to avoid the duplicate T(able)?
>
> That's not a bad idea, but IMHO deserves its own patch.
>
> I look forward to it!
> Rusty.
>
>
Here it is, boot tested on an SMP x86 box.
Sébastien.
Rename boot_gdt_table to boot_gdt to avoid the duplicate
T(able).
Signed-off-by: Sébastien Dugué <[EMAIL PROTECTED]>
---
arch/i386/kernel/head.S | 9 ++++-----
arch/i386/kernel/trampoline.S | 12 ++++++------
2 files changed, 10 insertions(+), 11 deletions(-)
Index: linux-2.6/arch/i386/kernel/head.S
===================================================================
--- linux-2.6.orig/arch/i386/kernel/head.S 2007-03-22 15:09:02.000000000
+0100
+++ linux-2.6/arch/i386/kernel/head.S 2007-03-22 16:14:38.000000000 +0100
@@ -147,8 +147,7 @@ page_pde_offset = (__PAGE_OFFSET >> 20);
/*
* Non-boot CPU entry point; entered from trampoline.S
* We can't lgdt here, because lgdt itself uses a data segment, but
- * we know the trampoline has already loaded the boot_gdt_table GDT
- * for us.
+ * we know the trampoline has already loaded the boot_gdt for us.
*
* If cpu hotplug is not supported then this code can go in init section
* which will be freed later
@@ -588,7 +587,7 @@ fault_msg:
.word 0 # 32 bit align gdt_desc.address
boot_gdt_descr:
.word __BOOT_DS+7
- .long boot_gdt_table - __PAGE_OFFSET
+ .long boot_gdt - __PAGE_OFFSET
.word 0 # 32-bit align idt_desc.address
idt_descr:
@@ -602,11 +601,11 @@ ENTRY(early_gdt_descr)
.long cpu_gdt_table
/*
- * The boot_gdt_table must mirror the equivalent in setup.S and is
+ * The boot_gdt must mirror the equivalent in setup.S and is
* used only for booting.
*/
.align L1_CACHE_BYTES
-ENTRY(boot_gdt_table)
+ENTRY(boot_gdt)
.fill GDT_ENTRY_BOOT_CS,8,0
.quad 0x00cf9a000000ffff /* kernel 4GB code at 0x00000000 */
.quad 0x00cf92000000ffff /* kernel 4GB data at 0x00000000 */
Index: linux-2.6/arch/i386/kernel/trampoline.S
===================================================================
--- linux-2.6.orig/arch/i386/kernel/trampoline.S 2007-03-22
15:09:02.000000000 +0100
+++ linux-2.6/arch/i386/kernel/trampoline.S 2007-03-22 16:13:23.000000000
+0100
@@ -29,7 +29,7 @@
*
* TYPE VALUE
* R_386_32 startup_32_smp
- * R_386_32 boot_gdt_table
+ * R_386_32 boot_gdt
*/
#include <linux/linkage.h>
@@ -62,8 +62,8 @@ r_base = .
* to 32 bit.
*/
- lidtl boot_idt - r_base # load idt with 0, 0
- lgdtl boot_gdt - r_base # load gdt with whatever is appropriate
+ lidtl boot_idt_descr - r_base # load idt with 0, 0
+ lgdtl boot_gdt_descr - r_base # load gdt with whatever is appropriate
xor %ax, %ax
inc %ax # protected mode (PE) bit
@@ -73,11 +73,11 @@ r_base = .
# These need to be in the same 64K segment as the above;
# hence we don't use the boot_gdt_descr defined in head.S
-boot_gdt:
+boot_gdt_descr:
.word __BOOT_DS + 7 # gdt limit
- .long boot_gdt_table-__PAGE_OFFSET # gdt base
+ .long boot_gdt - __PAGE_OFFSET # gdt base
-boot_idt:
+boot_idt_descr:
.word 0 # idt limit = 0
.long 0 # idt base = 0L
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
