When a ZONE_DEVICE page refcount reach 1 it means it is free and nobody
is holding a reference on it (only device to which the memory belong do).
Add a callback and call it when that happen so device driver can implement
their own free page management.

Changes since v2:
  - Move page refcount in put_zone_device_page()

Changes since v1:
  - Do not update devm_memremap_pages() to take extra argument

Signed-off-by: Jérôme Glisse <jgli...@redhat.com>
Cc: Dan Williams <dan.j.willi...@intel.com>
Cc: Ross Zwisler <ross.zwis...@linux.intel.com>
---
 include/linux/memremap.h |  6 ++++++
 kernel/memremap.c        | 11 ++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index 29d2cca..3e04f58 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -35,19 +35,25 @@ static inline struct vmem_altmap *to_vmem_altmap(unsigned 
long memmap_start)
 }
 #endif
 
+typedef void (*dev_page_free_t)(struct page *page, void *data);
+
 /**
  * struct dev_pagemap - metadata for ZONE_DEVICE mappings
+ * @page_free: free page callback when page refcount reach 1
  * @altmap: pre-allocated/reserved memory for vmemmap allocations
  * @res: physical address range covered by @ref
  * @ref: reference count that pins the devm_memremap_pages() mapping
  * @dev: host device of the mapping for debug
+ * @data: privata data pointer for page_free
  * @flags: memory flags see MEMORY_* in memory_hotplug.h
  */
 struct dev_pagemap {
+       dev_page_free_t page_free;
        struct vmem_altmap *altmap;
        const struct resource *res;
        struct percpu_ref *ref;
        struct device *dev;
+       void *data;
        int flags;
 };
 
diff --git a/kernel/memremap.c b/kernel/memremap.c
index c821946..19df1f5 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -190,7 +190,14 @@ EXPORT_SYMBOL(get_zone_device_page);
 
 void put_zone_device_page(struct page *page)
 {
-       page_ref_dec(page);
+       int count = page_ref_dec_return(page);
+
+       /*
+        * If refcount is 1 then page is freed and refcount is stable as nobody
+        * holds a reference on the page.
+        */
+       if (page->pgmap->page_free && count == 1)
+               page->pgmap->page_free(page, page->pgmap->data);
 
        put_dev_pagemap(page->pgmap);
 }
@@ -331,6 +338,8 @@ void *devm_memremap_pages(struct device *dev, struct 
resource *res,
        pgmap->ref = ref;
        pgmap->res = &page_map->res;
        pgmap->flags = MEMORY_DEVICE;
+       pgmap->page_free = NULL;
+       pgmap->data = NULL;
 
        mutex_lock(&pgmap_lock);
        error = 0;
-- 
2.4.11

Reply via email to