Matt Mackall wrote:
[...]
+ /* Allocate space for the mpi and its data */
+ s = (size / 4) + ((size % 4)? 1: 0);
Uhhh.. (size + 1) / 4?
You mean "(size + 3) / 4", no?
Overall, I agree with your comments: this file looks like it needs a lot
more CodingStyle ;)
Redefining standard kernel interfaces (error numbers, memory allocation,
printk, etc.) is not the right way to get code merged.
--
Paulo Marques - www.grupopie.com
"For every problem there is one solution which is simple, neat, and wrong."
H. L. Mencken
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
