On Tue, Feb 28, 2017 at 09:47:34PM +0100, Nicolas Dichtel wrote: > This patch prepares the uapi export by fixing the following error: > > .../linux/cryptouser.h:58:16: error: ‘CRYPTO_MAX_ALG_NAME’ undeclared here > (not in a function) > char cru_name[CRYPTO_MAX_ALG_NAME]; > > Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > --- > include/linux/crypto.h | 2 +- > include/uapi/linux/cryptouser.h | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index c0b0cf3d2d2f..4cf29a35bb4b 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -24,6 +24,7 @@ > #include <linux/slab.h> > #include <linux/string.h> > #include <linux/uaccess.h> > +#include <uapi/linux/cryptouser.h>
Nack. cryptouser is just one interface in the crypto API. It should not be included by every single crypto user in the kernel. You could perhaps introduce a new file under uapi just for this. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
