Hi Andy, On Tue, Feb 28, 2017 at 3:24 PM, Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote: >> This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d. >> >> It's very valuable to have modular tests, so you can run them just by >> insmodding the test modules, instead of needing a separate kernel that >> runs them at boot. >> >> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> >> --- >> lib/test_sort.c | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/lib/test_sort.c b/lib/test_sort.c >> index 4db3911db50ace76..d389c1cc2f6cf795 100644 >> --- a/lib/test_sort.c >> +++ b/lib/test_sort.c >> @@ -1,11 +1,8 @@ >> #include <linux/sort.h> >> #include <linux/slab.h> >> -#include <linux/init.h> >> +#include <linux/module.h> >> > >> >> -/* >> - * A simple boot-time regression test >> - * License: GPL >> - */ >> +/* a simple boot-time regression test */ > > I would leave this piece as is now.
As this is a revert, I prefer to revert 100%. > The rest is okay. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds