On Fri, Feb 24, 2017 at 3:17 AM, Chanwoo Choi <cw00.c...@samsung.com> wrote:
> On 2017년 02월 23일 19:31, Andy Shevchenko wrote:
>> First of all, add an optional binding for external muxer which might be
>> used.
>> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both
>> can be present as well.
>> - id-gpio: gpio for USB ID pin. See gpio binding.
>> - vbus-gpio: gpio for USB VBUS pin.
>>
>> +Optional properties:
>> +- mux-gpios: gpio for USB external muxer
>
> The Documentation/extcon/intel-int3496.txt includes
> already the information for id/vbus/mux pin.
Thanks for pointing this out...
> The extcon-usb-gpio.txt is not related with the extcon-int3496 driver.
...but the bindings is related to ACPI somehow. I dunno why in
extcon-usb-gpio.c we have
if (!np && !ACPI_HANDLE(dev))
...and thus it means either firmware chooses we better to have
standardized bindings in both cases.
OTOH mux-gpios indeed doesn't make sense for extcon-usb-gpio.c and
would be removed from the bindings.
I'll update patches accordingly.
--
With Best Regards,
Andy Shevchenko
