But it is shorter than from JFK or Newark. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Keir Fraser Sent: Friday, March 16, 2007 6:58 AM To: Andrew Morton; Keir Fraser Cc: [EMAIL PROTECTED]; Andi Kleen; linux-kernel@vger.kernel.org; Keir Fraser; Wright; virtualization@lists.osdl.org; Ingo Molnar; [EMAIL PROTECTED] Subject: Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console
On 16/3/07 11:41, "Andrew Morton" <[EMAIL PROTECTED]> wrote: >> It's needed for writing data /after/ reading the consumer index that shows >> you have space to write. Looking through xenbus_comms.c I think all the >> barriers are correct except there is a spurious extra mb() in xb_read(), >> where there is a later rmb() which is sufficient by itself. All the others >> have a purpose. >> > > If Ingo couldn't work this out from reading the code then nobody else can, > and we have a maintainability problem which can only be solved with > adequate commenting. Agreed. I've fixed up the commenting, removed the spurious mb(), and I just need Jeremy to merge that change into the Xen pv_ops patchset. :-) -- Keir _______________________________________________ Xen-devel mailing list [EMAIL PROTECTED] http://lists.xensource.com/xen-devel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
