On Mon, 13 Feb 2017 09:14:21 +0100
Nicholas Mc Guire <der.h...@hofr.at> wrote:
> This fixes a sparse warning about incorrect type in retrun expression
^return
and you miss a comma at the end of this sentence.
>
> Signed-off-by: Nicholas Mc Guire <der.h...@hofr.at>
You forgot to add my ack (same comment on your other patches).
> ---
>
> V2: fixed prefix and the truncated commit message noted by Boris Brezillon
> <boris.brezil...@free-electrons.com> - thanks!
>
> sparse complained about:
> drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return
> expression (different address spaces)
> drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi *
> drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base
>
> Patch was compile tested with: multi_v7_defconfig (implies
> CONFIG_MTD_SPI_NOR=y)
>
> Patch is against 4.10-rc7 (localversion-next is next-20170213)
>
> drivers/mtd/spi-nor/intel-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index 2956f2c..1a6de4b 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
>
> ispi->base = devm_ioremap_resource(dev, mem);
> if (IS_ERR(ispi->base))
> - return ispi->base;
> + return ERR_CAST(ispi->base);
>
> ispi->dev = dev;
> ispi->info = info;
