On Mon, 13 Feb 2017 07:35:52 +0000 Nicholas Mc Guire <der.h...@hofr.at> wrote:
> On Sun, Feb 12, 2017 at 11:04:10PM +0100, Boris Brezillon wrote: > > +Mika > > > > On Sun, 12 Feb 2017 22:45:43 +0100 > > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > > > On Sun, 12 Feb 2017 17:43:43 +0100 > > > Nicholas Mc Guire <der.h...@hofr.at> wrote: > > > > > > > This fixes a sparse warning about > > > > > > Your commit message seems to be incomplete. > > > > And here too, please change the prefix to "mtd: spi-nor: intel: ". > > > > What Im doing for checking prefix is: > hofrat@debian:~/git/linux-next$ git log --oneline > drivers/mtd/spi-nor/intel-spi.c > 8afda8b spi-nor: Add support for Intel SPI serial flash controller > > is the method of checking the commit prefix with git log --oneline > inapropriate ? It's appropriate, except in this case. You're referring to the commit introducing a new driver, so this is expected to not find the 'intel:' suffix, but you have 'Add support for Intel SPI serial flash controller' to clarify the scope. Regarding the "mtd: " prefix, I think it's better to have it, but apparently Cyrille is not enforcing that. > How would I have found the "mtd: spi-nor: intel:" in this case ? Well, it's a mix of common sense and 'git log --oneline' use :-). Here you're only modifying the intel driver, but nothing in your subject mentions it.
