On Wed, Mar 14 2007, Nick Piggin wrote: > > Splice does not need to readpage to bring the page uptodate before writing > to it, because prepare_write will take care of that for us.
Ah great, always good to get rid of some code. > Splice is also wrong to SetPageUptodate before the page is actually uptodate. > This results in the old uninitialised memory leak. This gets fixed as a > matter of course when removing the readpage logic. Leak, how? The page should still be locked all through to the copy. Anyway, doesn't matter since you've killed it anyway. I have applied this patch. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
