Hi, Thanks for your review.
> -----Original Message----- > From: Mark Salyzyn [mailto:saly...@android.com] > Sent: Friday, February 03, 2017 7:18 AM > To: 岩松信洋 / IWAMATSU，NOBUHIRO; Anton Vorontsov; Colin Cross; Kees Cook; > Tony Luck > Cc: linux-kernel@vger.kernel.org; Hiraku Toyooka; 阿口誠司 / AGUCHI， > SEIJI > Subject: Re: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances > > On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote: > > diff --git a/include/linux/pstore.h b/include/linux/pstore.h index > > 0da29cae009b..7a5db4833b8a 100644 > > --- a/include/linux/pstore.h > > +++ b/include/linux/pstore.h > > @@ -55,6 +55,7 @@ struct pstore_info { > > size_t bufsize; > > struct mutex read_mutex; /* serialize open/read/close */ > > int flags; > > + unsigned int num_pmsg; > > int (*open)(struct pstore_info *psi); > > int (*close)(struct pstore_info *psi); > > ssize_t (*read)(u64 *id, enum pstore_type_id *type, > > Before patch there was an implication that num_pmsg was 1, after patch calloc > leaves this at a value of 0. Please reconcile the functional difference > that this causes. Yes, I was pointed out here also by Kees. I will fix this. Best regards, Nobuhiro
