On 2 February 2017 at 03:42, Alexander Shishkin <alexander.shish...@linux.intel.com> wrote: > Mathieu Poirier <mathieu.poir...@linaro.org> writes: > >> Do we have two different syntax to specify the same behaviour? >> >> For example we have: >> >> --filter 'start 0x80082570/0x644' >> >> and >> >> --filter 'filter 0x80082570/0x644' >> >> Both will end up with filter->filter == 1 and filter->range == 1. > > This is another reason why enum action is needed. The difference between > 'start' and 'filter' is that the former means "start tracing when you > enter this region until something else stops it";
And what is the "something else here"? > the latter means > "trace only inside this region" (that is, start tracing when you branch > inside this region and stop when you branch outside). That is indeed how range filters work on CS. > They cannot be > treated interchangeably as I originally though. PT supports 'filter', CS > supports 'start', if I remember right. So we should make sure to > -EOPNOTSUPP things that we don't actually support. I already published slides at 2 conferences that uses "filter" for range filters. On CS I will have to continue using "filter" and "start" (when specified with a size element) as one and the same. > > Regards, > -- > Alex
