On Tue, 2007-03-13 at 21:39 -0700, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > This is called "pissing in the corners". Don't do it: we don't need to > > touch that code and I actually prefer the original anyway (explicit is > > *good*). > > > > The habit of extracting cpu number once then using it is an optimization > > which we should be aiming to get rid of (it simply hurts archs with > > efficient per-cpu implementations). > > No, that was for a reason. I was worried about smp_processor_id() not > returning valid values between init_gdt and cpu_set_gdt. It's not > actually a problem, but relying on smp_processor_id() while we're moving > the foundations its based on seems fragile.
smp_processor_id() always works, so it's fundamental, not fragile. However, we *should* remove the arg from cpu_set_gdt, since we have such faith in smp_processor_id() 8) Cheers, Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
