>-----Original Message----- >From: Arseny Solokha [mailto:asolo...@kb.kras.ru] >Sent: Sunday, January 29, 2017 2:52 PM >To: Claudiu Manoil <claudiu.man...@nxp.com> >Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Arseny Solokha ><asolo...@kb.kras.ru> >Subject: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ >gfar_new_page > >From: Arseny Solokha <asolo...@kb.kras.ru> > >In spite of switching to paged allocation of Rx buffers, the driver still >called dma_unmap_single() in the Rx queues tear-down path. >
Except for the dma-debug part generating the warning, the implementation of dma_unmap_single() looks identical to dma_unmap_page(), both wrappers calling ops->unmap_page() with same params. But for consistency, dma_unmap_page() seems the better choice indeed. Thanks. Acked-by: Claudiu Manoil <claudiu.man...@nxp.com>
