Commit-ID:  42e233cacc052bd545417c68155f2b9abd1bab72
Gitweb:     http://git.kernel.org/tip/42e233cacc052bd545417c68155f2b9abd1bab72
Author:     Markus Elfring <elfr...@users.sourceforge.net>
AuthorDate: Mon, 23 Jan 2017 14:54:26 +0100
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Thu, 26 Jan 2017 11:42:55 -0300

perf probe: Delete an unnecessary check in try_to_find_absolute_address()

Remove a condition check which is unnecessary at the end
because this source code place should usually only be reached
with a non-zero pointer.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Acked-by: Masami Hiramatsu <mhira...@kernel.org>
Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: Alexander Shishkin <alexander.shish...@linux.intel.com>
Cc: He Kuang <heku...@huawei.com>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Milian Wolff <milian.wo...@kdab.com>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Ravi Bangoria <ravi.bango...@linux.vnet.ibm.com>
Cc: Wang Nan <wangn...@huawei.com>
Cc: kernel-janit...@vger.kernel.org
Link: 
http://lkml.kernel.org/r/a3f2473b-6383-a326-bce0-b82642360...@users.sourceforge.net
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/util/probe-event.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 4a57c8a..cdfc468 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -3004,10 +3004,8 @@ static int try_to_find_absolute_address(struct 
perf_probe_event *pev,
        return 1;
 
 errout:
-       if (*tevs) {
-               clear_probe_trace_events(*tevs, 1);
-               *tevs = NULL;
-       }
+       clear_probe_trace_events(*tevs, 1);
+       *tevs = NULL;
        return err;
 }
 

Reply via email to