David, Am 24.01.2017 um 23:57 schrieb David Binderman: >>> fs/jffs2/readinode.c:189]: (style) Condition 'tn.fn.ofs>=offset' is always >>> true > >>What tool produces this info? > > A static analyser for C and C++ called cppcheck, available from sourceforge.
That needs to go into the changelog. >>That code is odd, yes. But we need more info. >>Why is fn.fn.ofs>=offset always true? > > Doh. By obvious inspection of the code. > If test x < y fails, then x must be >= y. So tn.fn.ofs>=offset is _not_ always true. The else branch is always false. Thanks, //richard
