> > From: Christian Borntraeger [mailto:borntrae...@de.ibm.com] > Sent: Friday, January 13, 2017 4:28 PM > To: Gonglei (Arei); virtualizat...@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: m...@redhat.com; herb...@gondor.apana.org.au > Subject: Re: [PATCH] virtio-crypto: adjust priority of algorithm > > ACK. Whoever takes this patch might want to fixup 3 typos. > Thanks, I'd better send v2 IMHO. :)
Regards, -Gonglei > On 01/13/2017 07:25 AM, Gonglei wrote: > > > Some hardware accelerators (like intel aseni or the s390 > aesni > > cpacf functions) have lower priorities than virtio > > crypto, and those drivers are faster than the same in > > the host via virtio. So let's lower the priority of > > virtio-crypto's algorithm, make it's higher than sofeware > software > > implimentations but lower than the hardware ones. > implementations > > > > Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > > --- > > drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c > b/drivers/crypto/virtio/virtio_crypto_algs.c > > index 6f40a42..4de4740 100644 > > --- a/drivers/crypto/virtio/virtio_crypto_algs.c > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.c > > @@ -498,7 +498,7 @@ void virtio_crypto_ablkcipher_finalize_req( > > static struct crypto_alg virtio_crypto_algs[] = { { > > .cra_name = "cbc(aes)", > > .cra_driver_name = "virtio_crypto_aes_cbc", > > - .cra_priority = 501, > > + .cra_priority = 150, > > .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC, > > .cra_blocksize = AES_BLOCK_SIZE, > > .cra_ctxsize = sizeof(struct virtio_crypto_ablkcipher_ctx), > >