Re: [PATCH 2/4] efi/x86: move efi bgrt init code to early init code

[Dave Young]

[snip]
> --- linux-x86.orig/drivers/acpi/bgrt.c
> +++ linux-x86/drivers/acpi/bgrt.c

[snip]
>  
> @@ -84,9 +85,17 @@ static int __init bgrt_init(void)
>  {
>       int ret;
>  
> -     if (!bgrt_image)
> +     if (!bgrt_tab.image_address)
>               return -ENODEV;
>  
> +     bgrt_image = memremap(bgrt_tab.image_address, bgrt_image_size,
> +                           MEMREMAP_WB);
> +     if (!bgrt_image) {
> +             pr_notice("Ignoring BGRT: failed to map image memory\n");
> +             bgrt_image = NULL;
> +             return -ENOMEM;
> +     }
> +

Oops, later error path need unmap bgrt_image, will update in next
version after collecting more comments.

Also bgrt_image = NULL is useless, will drop it.

>       bin_attr_image.private = bgrt_image;
>       bin_attr_image.size = bgrt_image_size;
>  

Thanks
Dave