On 067, 03 08, 2007 at 11:14:01PM -0800, Amit Choudhary wrote: > Description: Check the return value of kmalloc() in function > videocodec_build_table(), in file drivers/media/video/videocodec.c. > > Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> > > diff --git a/drivers/media/video/videocodec.c > b/drivers/media/video/videocodec.c > index 2ae3fb2..16fc1dd 100644 > --- a/drivers/media/video/videocodec.c > +++ b/drivers/media/video/videocodec.c > @@ -348,6 +348,8 @@ #define LINESIZE 100 > kfree(videocodec_buf); > videocodec_buf = (char *) kmalloc(size, GFP_KERNEL); > > + if (!videocodec_buf) > + return 0; > i = 0; > i += scnprintf(videocodec_buf + i, size - 1, > "<S>lave or attached <M>aster name type flags magic > ");
Can you also remove useless (char *) cast above ? -- Andrey Panin | Linux and UNIX system administrator [EMAIL PROTECTED] | PGP key: wwwkeys.pgp.net
signature.asc
Description: Digital signature
