On 01/04/2017 11:56 AM, Michal Hocko wrote:
> On Wed 04-01-17 11:47:56, Vlastimil Babka wrote:
>> On 12/20/2016 02:01 PM, Michal Hocko wrote:
>>> From: Michal Hocko <[email protected]>
>>
>> --------8<--------
>> From: Vlastimil Babka <[email protected]>
>> Date: Wed, 4 Jan 2017 11:44:09 +0100
>> Subject: [PATCH] oom, trace: add compaction retry tracepoint-fix
>>
>> Let's print the compaction priorities lower-case and without
>> prefix for consistency.
>>
>> Also indent fix in compact_result_to_feedback().
>>
>> Signed-off-by: Vlastimil Babka <[email protected]>
>
> I would just worry that c&p constant name is easier to work with when
> vim -t $PRIO or git grep $PRIO. But if the lowercase and shorter sounds
> better to you then no objections from me.
Yeah, valid point, but since we didn't do that until now, let's stay
consistent.
>> ---
>> include/trace/events/mmflags.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h
>> index aa4caa6914a9..e4c3a0febcce 100644
>> --- a/include/trace/events/mmflags.h
>> +++ b/include/trace/events/mmflags.h
>> @@ -195,7 +195,7 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty"
>> ) \
>>
>> #define compact_result_to_feedback(result) \
>> ({ \
>> - enum compact_result __result = result; \
>> + enum compact_result __result = result; \
>> (compaction_failed(__result)) ? COMPACTION_FAILED : \
>> (compaction_withdrawn(__result)) ? COMPACTION_WITHDRAWN :
>> COMPACTION_PROGRESS; \
>> })
>> @@ -206,9 +206,9 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty"
>> ) \
>> EMe(COMPACTION_PROGRESS, "progress")
>>
>> #define COMPACTION_PRIORITY \
>> - EM(COMPACT_PRIO_SYNC_FULL, "COMPACT_PRIO_SYNC_FULL") \
>> - EM(COMPACT_PRIO_SYNC_LIGHT, "COMPACT_PRIO_SYNC_LIGHT") \
>> - EMe(COMPACT_PRIO_ASYNC, "COMPACT_PRIO_ASYNC")
>> + EM(COMPACT_PRIO_SYNC_FULL, "sync_full") \
>> + EM(COMPACT_PRIO_SYNC_LIGHT, "sync_light") \
>> + EMe(COMPACT_PRIO_ASYNC, "async")
>> #else
>> #define COMPACTION_STATUS
>> #define COMPACTION_PRIORITY
>> --
>> 2.11.0
>>
>
