If 'of_find_device_by_node()' fails, an 'of_node_put()' call is missing in
the error handling path.
Fix it by reordering the code.

While at it, remove some empty lines in a more or less similar construction
a few lines below.

Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
---
 drivers/memory/tegra/tegra124-emc.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/memory/tegra/tegra124-emc.c 
b/drivers/memory/tegra/tegra124-emc.c
index 06cc781ebac1..392dc8dd481f 100644
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -1115,11 +1115,10 @@ static int tegra_emc_probe(struct platform_device *pdev)
        }
 
        mc = of_find_device_by_node(np);
+       of_node_put(np);
        if (!mc)
                return -ENOENT;
 
-       of_node_put(np);
-
        emc->mc = platform_get_drvdata(mc);
        if (!emc->mc)
                return -EPROBE_DEFER;
@@ -1135,9 +1134,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
        }
 
        err = tegra_emc_load_timings_from_dt(emc, np);
-
        of_node_put(np);
-
        if (err)
                return err;
 
-- 
2.9.3

Reply via email to