Thanks Linus for fixing this. Nehal
-----Original Message----- From: Linus Walleij [mailto:linus.wall...@linaro.org] Sent: Tuesday, January 3, 2017 1:51 PM To: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org Cc: linux-g...@vger.kernel.org; Linus Walleij <linus.wall...@linaro.org>; S-k, Shyam-sundar <shyam-sundar....@amd.com>; Shah, Nehal-bakulchandra <nehal-bakulchandra.s...@amd.com> Subject: [PATCH] pinctrl: amd: fix compilation warning 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") created the following warning: drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] for (; i < pin_num; i++) { ^ drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned int bank, i, pin_num; ^ Fix this by adding a guarding default case for illegal bank numbers. Cc: S-k Shyam-sundar <shyam-sundar....@amd.com> Cc: Nehal Shah <nehal-bakulchandra.s...@amd.com> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- drivers/pinctrl/pinctrl-amd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 47b17100410e..c2203699f1ab 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -206,6 +206,9 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) i = 192; pin_num = AMD_GPIO_PINS_BANK3 + i; break; + default: + /* Illegal bank number, ignore */ + continue; } for (; i < pin_num; i++) { seq_printf(s, "pin%d\t", i); -- 2.9.3
