On Wed, Dec 28, 2016 at 02:57:08PM -0800, Stephen Boyd wrote:
> The CI_HDRC_CONTROLLER_STOPPED_EVENT may want to call sleeping
> APIs similar to how _gadget_stop_activity() may. Let's drop the
> lock across the event so that glue drivers can make sleeping
> calls.
> 
> Cc: Peter Chen <peter.c...@nxp.com>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: Stephen Boyd <stephen.b...@linaro.org>
> ---
>  drivers/usb/chipidea/udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 0db56fb7e9e9..0d532a724d48 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1793,10 +1793,10 @@ static int ci_udc_stop(struct usb_gadget *gadget)
>  
>       if (ci->vbus_active) {
>               hw_device_state(ci, 0);
> +             spin_unlock_irqrestore(&ci->lock, flags);
>               if (ci->platdata->notify_event)
>                       ci->platdata->notify_event(ci,
>                       CI_HDRC_CONTROLLER_STOPPED_EVENT);
> -             spin_unlock_irqrestore(&ci->lock, flags);
>               _gadget_stop_activity(&ci->gadget);
>               spin_lock_irqsave(&ci->lock, flags);
>               pm_runtime_put(&ci->gadget.dev);
> -- 

Acked-by: Peter Chen <peter.c...@nxp.com>

-- 

Best Regards,
Peter Chen

Reply via email to