On Wednesday 07 March 2007 18:11, Greg KH wrote: > From: "Paolo 'Blaisorblade' Giarrusso" <[EMAIL PROTECTED]> > > There is no prompt for STACKTRACE, so it is enabled only when 'select'ed. > FAULT_INJECTION depends on it, while LOCKDEP selects it. So FAULT_INJECTION > becomes visible in Kconfig only when LOCKDEP is enabled.
Please replace with the attached patch, sorry for being late (I thought it had been dropped). Otherwise a regression would be caused for archs like ia64 on allyesconfig; the change is needed, as discussed with Roman Zippel. > Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > --- > lib/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.20.1.orig/lib/Kconfig.debug > +++ linux-2.6.20.1/lib/Kconfig.debug > @@ -400,7 +400,7 @@ config LKDTM > config FAULT_INJECTION > bool "Fault-injection framework" > depends on DEBUG_KERNEL > - depends on STACKTRACE > + select STACKTRACE > select FRAME_POINTER > help > Provide fault-injection framework. > > -- -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade
[PATCH] Kconfig: FAULT_INJECTION can be selected only if LOCKDEP is enabled. There is no prompt for STACKTRACE, so it is enabled only when 'select'ed. FAULT_INJECTION depends on it, while LOCKDEP selects it. So FAULT_INJECTION becomes visible in Kconfig only when LOCKDEP is enabled. Update: fixed for architectures not supporting STACKTRACE_SUPPORT. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Index: linux-2.6.git/lib/Kconfig.debug =================================================================== --- linux-2.6.git.orig/lib/Kconfig.debug +++ linux-2.6.git/lib/Kconfig.debug @@ -399,8 +399,8 @@ config LKDTM config FAULT_INJECTION bool "Fault-injection framework" - depends on DEBUG_KERNEL - depends on STACKTRACE + depends on DEBUG_KERNEL && STACKTRACE_SUPPORT + select STACKTRACE select FRAME_POINTER help Provide fault-injection framework.
