On Wed, Mar 07, 2007 at 11:40:53PM +0100, Pavel Machek wrote: > Hi! > > > o Various cleanups. One of the main purpose of cleanups is that make > > wakeup.S as close as possible to trampoline.S. > > > > o Following are the changes > > - Indentations for comments. > > - Changed the gdt table to compact form and to resemble the > > one in trampoline.S > > - Take the jump to 32bit from real mode using ljmpl. Makes code > > more readable. > > - After enabling long mode, directly take a long jump for 64bit > > mode. No need to take an extra jump to "reach_comaptibility_mode" > > - Stack is not used after real mode. So don't load stack in > > 32 bit mode. > > - No need to enable PGE here. > > - No need to do extra EFER read, anyway we trash the read contents. > > - No need to enable system call (EFER_SCE). Anyway it will be > > enabled when original EFER is restored. > > - No need to set MP, ET, NE, WP, AM bits in cr0. Very soon we will > > reload the original cr0 while restroing the processor state. > > > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > > Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]> > > ACK, provided it was tested. > Pavel
Hi Pavel, Thanks. I tested all the S3 related changes during my last posting. That time I had access to an x86_64 box which supported ACPI state S3. Since then this code has not changed and it has been running successfully in RHEL5 kernels. Now I don't have access to an x86_64 machine which supports S3 so I can't test suspend to RAM. But I am sure that these patches are working as nothing has changed since last posting. Just now Nigel reported successful suspend to RAM results for 2.6.20. I have requested him to test it for 2.6.21-rc2 also, if possible. I have throughly tested suspend to disk (S4) and it works fine. Thanks Vivek - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
