On December 14, 2016 6:42 AM, Piotr Gregor wrote: > Add names of parameters to function prototypes in comedi PCI. > Checkpatch reports now no errors. > > Signed-off-by: Piotr Gregor <piotrgre...@rsyncme.org> > --- > drivers/staging/comedi/comedi_pci.h | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/comedi/comedi_pci.h > b/drivers/staging/comedi/comedi_pci.h > index 4005cc9..7dfd892 100644 > --- a/drivers/staging/comedi/comedi_pci.h > +++ b/drivers/staging/comedi/comedi_pci.h > @@ -34,18 +34,20 @@ > #define PCI_VENDOR_ID_RTD 0x1435 > #define PCI_VENDOR_ID_HUMUSOFT 0x186c > > -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); > +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev); For the function prototypes I prefer no names for the "pointer" parameters.
The "struct foo *" declaration is just as clear as "struct foo *bar". Thanks, Hartley
