Al Viro <v...@zeniv.linux.org.uk> wrote: > > I understand wanting to avoid extra arguments, but you are asking for > > trouble with that sort of calling conventions. Verifying that all call > > chains have these fields initialized is bloody unpleasant and it *is* > > going to break, especially since the rules are "you need to initialize it > > for vfs_xgetattr(), but not for vfs_getattr()" - the names are similar > > enough for confusion, and that's not the only such pair. > > BTW, after some grepping: you seem to leave ecryptfs_getattr() as-is, which > means that flags it had been passed by caller in *stat are not seen by > underlying fs. Looks fishy...
I have patches for some other filesystems as well, but I'm trying to nail the core down before whipping those back into shape. David
