On Mon, 5 Mar 2007 17:37:56 -0800
Randy Dunlap <[EMAIL PROTECTED]> wrote:
> On Mon, 05 Mar 2007 18:03:59 -0600 Robert Peterson wrote:
>
> > This is try #2 for this patch, with corrections based on feedback.
> > It is the same as the previous patch except:
> > (1) The function has been renamed from lookup_symbol to sprint_symbol
> > as requested by Paulo Marques.
> > (2) I fixed the "return NULL;" to "return;" as pointed out by Paulo Marques
> > for the case where the kallsyms function is not selected in .config
> > (3) I changed EXPORT_SYMBOL to EXPORT_SYMBOL_GPL as
> > requested by Roman Zippel. (Andrew, I thought you said you changed this,
> > but I didn't see it in mm1).
> >
> > I hope this patch attaches with proper spacing and without word wrap.
> > If it doesn't, my apologies (I'm using Thunderbird, but suggestions
> > welcome).
> >
> > Original comment:
> >
> > Today's print_symbol function dumps a kernel symbol with printk.
> > This patch extends the functionality of kallsyms.c so that the symbol
> > lookup function may be used without the printk. This is
> > useful for modules that want to dump symbols elsewhere, for
> > example, to debugfs. I intend to use the new function call in the
> > GFS2 file system (which will be a separate patch).
> >
> > Signed-off-by: Robert Peterson <[EMAIL PROTECTED]>
> > ---
>
> argh, attachment, harder to review/comment on....
>
> I had commented on this comment, but you seem to have missed it.
>
> +/* Replace "%s" in format with address, or returns -errno. */
> +void __print_symbol(const char *fmt, unsigned long address)
> +{
>
> This function does not "returns -errno" at all.
I think the arguments to sprint_symbol() are backwards. Would prefer
sprint_symbol(char *buffer, unsigned long addr)
like all the other print-into-a-buffer functions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
