On Fri, 16 Feb 2007, David Howells wrote: > Robin Holt <[EMAIL PROTECTED]> wrote: > > > How about: > > if (vma->vm_mm->coredump_omit_anon_shared) { > > > > Then the calls to maydump() would be unchanged: > > VMAs are a shared resource under NOMMU conditions.
That's a disturbing remark. Under precisely what NOMMU conditions? I had thought Robin's suggestion very sensible; and throughout mm/ it has seemed pretty random whether we pass an "mm" argument down in addition to "vma", or just take vma->vm_mm at whatever level needs. You seem to be suggesting vma->vm_mm is dangerous when CONFIG_NOMMU, but we MMU people are scarily unaware of that. Perhaps you need to put #ifndef CONFIG_NOMMU around vm_mm in struct vm_area_struct? Or am I totally misunderstanding? Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/