On Fri, Nov 11, 2016 at 08:50:17AM +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > > Scatterlist entries have an unsigned int for the offset so > correct the sg_alloc_table_from_pages function accordingly. > > Since these are offsets withing a page, unsigned int is > wide enough. > > Also converts callers which were using unsigned long locally > with the lower_32_bits annotation to make it explicitly > clear what is happening. > > v2: Use offset_in_page. (Chris Wilson) > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > Cc: Pawel Osciak <pa...@osciak.com> > Cc: Marek Szyprowski <m.szyprow...@samsung.com> > Cc: Kyungmin Park <kyungmin.p...@samsung.com> > Cc: Tomasz Stanislawski <t.stanisl...@samsung.com> > Cc: Matt Porter <mpor...@kernel.crashing.org> > Cc: Alexandre Bounine <alexandre.boun...@idt.com> > Cc: linux-me...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Marek Szyprowski <m.szyprow...@samsung.com> (v1)
If there were kerneldoc, it would nicely explain that having an offset larger then a page is silly when passing in array of pages. Changes elsewhere look ok (personally I'd be happy with just offset_in_page(), 4GiB superpages are somebody else's problem :) Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre
