On Fri, Nov 11, 2016 at 12:39 AM, Miklos Szeredi <mik...@szeredi.hu> wrote: > New version is at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #redirect > > News: > - it actually should work in all cases > - when rename is not cross directory, just store the new name instead > of a full path, as suggested by Amir > - when redirect path is too long fall back to EXDEV (the max length > should probably be a module param) >
Looks goods, except for the case of change from relative to absolute redirect of the victim dentry. IIUC, ovl_set_redirect() will return immediately because ovl_dentry_is_redirect() and will not get to setting the absolute redirect. It passed my sanity tests (including recycle test) and on top of my copy up lock changes. You can add Reviewed-by/Tested-by me to 1380846 ovl: redirect on rename-dir > About turning the feature on or off. Yes, maybe the empty checking is > too complicated. Going one simpler: > > - default to old behavior, turn on with mount option > - add module option and kernel compile option to turn on the feature by > default > I don't see these changes on your branch. Are these your plans for a future version? Thanks, Amir.
