On Thursday, November 10, 2016 10:26:09 AM John Stultz wrote: > On Wed, Nov 9, 2016 at 8:55 PM, Chen Yu <yu.c.c...@intel.com> wrote: > > Previously we encountered some memory overflow issues due to > > the bogus sleep time brought by inconsistent rtc, which is > > triggered when pm_trace is enabled, and we have fixed it > > in recent kernel. However it's improper in the first place > > to call __timekeeping_inject_sleeptime() in case that pm_trace > > is enabled simply because that "hash" time value will wreckage > > the timekeeping subsystem. > > > > This patch is originally written by Thomas, which would bypass > > the bogus rtc interval when pm_trace is enabled. > > Meanwhile, if system succeed to resume back with pm_trace set, the > > users are warned to adjust the bogus rtc either by ntp-date or rdate, > > by resetting pm_trace_rtc_abused to false, otherwise above tools might > > not work as expected. > > > > Originally-from: Thomas Gleixner <t...@linutronix.de> > > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > > Cc: John Stultz <john.stu...@linaro.org> > > Cc: Xunlei Pang <xlp...@redhat.com> > > Cc: Ingo Molnar <mi...@redhat.com> > > Cc: Len Brown <l...@kernel.org> > > Cc: "H. Peter Anvin" <h...@zytor.com> > > Cc: Pavel Machek <pa...@ucw.cz> > > Cc: Thomas Gleixner <t...@linutronix.de> > > Signed-off-by: Chen Yu <yu.c.c...@intel.com> > > > Looks ok to me. I'm queueing it up for testing. If no one objects > (and I don't see any issues) I'll merge it to my tree and push it to > -tip through Thomas.
No objections here, thanks John! Cheers, Rafael