On Tue, Nov 08, 2016 at 03:10:40PM -0800, Andrew Morton wrote: > I already have the below. Good enough?
Sure, good enough. Though it does have the same tiny awkwardness as my v1. > From: Jerome Forissier <jerome.foriss...@linaro.org> > Subject: checkpatch: don't try to get maintained status when --no-tree is > given > > Fixes the following warning: > Use of uninitialized value $root in concatenation (.) or string at > /path/to/checkpatch.pl line 764. > > Link: > http://lkml.kernel.org/r/1476719709-16668-1-git-send-email-jerome.foriss...@linaro.org > Signed-off-by: Jerome Forissier <jerome.foriss...@linaro.org> > Acked-by: Joe Perches <j...@perches.com> > Signed-off-by: Andrew Morton <a...@linux-foundation.org> > --- > > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN > scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given > scripts/checkpatch.pl > --- > a/scripts/checkpatch.pl~checkpatch-dont-try-to-get-maintained-status-when-no-tree-is-given > +++ a/scripts/checkpatch.pl > @@ -761,7 +761,7 @@ sub seed_camelcase_file { > sub is_maintained_obsolete { > my ($filename) = @_; > > - return 0 if (!(-e "$root/scripts/get_maintainer.pl")); > + return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl")); > > my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol > --nogit --nogit-fallback -f $filename 2>&1`; > > _ > FWIW: Reviewed-by: Brian Norris <computersforpe...@gmail.com>
