On Mon, Nov 7, 2016 at 5:53 PM, Andrey Smirnov <andrew.smir...@gmail.com> wrote:
> The difference between 8 and 16 pin GPIO expanders can be accomodated by > the means of regmap API without resorting to usaing driver-specific > read/write accessors. This change, IMHO, brings the following benefits: > > - Replaces driver's idiosyncratic way of dealing with > mult-register fields with regmap API, which, hopefuly, > makes the code a bit easier for a new reader to understand > > - Removes various multi-read for-loop register read logic > from various places in the code and puts it in a signle > place > > - Removes ad-hoc IRQ register caching code in > sx150x_irq_bus_sync_unlock, since that functionality is > provided by regmap > > Besided aforementioned benefits this change also implements necessary > RegSense byte swap necessary for SX1503 and SX1506 variants of the chip. > > Tested-by: Neil Armstrong <narmstr...@baylibre.com> > Acked-by: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com> Patch applied! Yours, Linus Walleij
