On Sat, Oct 29, 2016 at 09:36:57PM +0200, Julia Lawall wrote: > Use DEVICE_ATTR_RO for read only attributes. This simplifies the source > code, improves readbility, and reduces the chance of inconsistencies. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @ro@ > declarer name DEVICE_ATTR; > identifier x,x_show; > @@ > > DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL); > > @script:ocaml@ > x << ro.x; > x_show << ro.x_show; > @@ > > if not (x^"_show" = x_show) then Coccilib.include_match false > > @@ > declarer name DEVICE_ATTR_RO; > identifier ro.x,ro.x_show; > @@ > > - DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL); > + DEVICE_ATTR_RO(x); > // </smpl> > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > ---
Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> Thanks, Charles
