On 10/26, Josh Poimboeuf wrote: > > On Wed, Oct 26, 2016 at 04:14:00PM +0200, Oleg Nesterov wrote: > > +/* > > + * TODO: kill it and use to_kthread(). But we still need the users > > + * like kthread_stop() which has to sync with the exiting kthread. > > + */ > > static struct kthread *to_live_kthread(struct task_struct *k) > > Now that the kthread struct is no longer on the stack, are the > try_get_task_stack() and its corresponding put_task_stack()'s still > needed?
It seems you missed this part Of course, with this patch we are ready to remove put_task_stack() from kthread.c right now. The next change should kill to_live_kthread() altogether. in the same email ;) Oleg.