> On Oct 24, 2016, at 11:37 PM, Vignesh R <vigne...@ti.com> wrote: > > > > On Tuesday 25 October 2016 11:46 AM, John Syne wrote: >> >>> On Oct 24, 2016, at 11:01 PM, John Syne <john3...@gmail.com> wrote: >>> >>>> >>>> On Oct 24, 2016, at 10:52 PM, Mugunthan V N <mugunthan...@ti.com> wrote: >>>> > [...] >>>>>>> >>>>>>> --- >>>>>>> include/linux/mfd/ti_am335x_tscadc.h | 4 ++-- >>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/include/linux/mfd/ti_am335x_tscadc.h >>>>>>> b/include/linux/mfd/ti_am335x_tscadc.h >>>>>>> index b9a53e0..96c4207 100644 >>>>>>> --- a/include/linux/mfd/ti_am335x_tscadc.h >>>>>>> +++ b/include/linux/mfd/ti_am335x_tscadc.h >>>>>>> @@ -90,7 +90,7 @@ >>>>>>> /* Delay register */ >>>>>>> #define STEPDELAY_OPEN_MASK (0x3FFFF << 0) >>>>>>> #define STEPDELAY_OPEN(val) ((val) << 0) >>>>>>> -#define STEPCONFIG_OPENDLY STEPDELAY_OPEN(0x098) >>>>> Wouldn’t this be better to add this to the devicetree? >>>>> >>>>> ti,chan-step-avg = <0x16 0x16 0x16 0x16 0x16 0x16 0x16>; >>>>> ti,chan-step-opendelay = <0x500 0x500 0x500 0x500 0x500 0x500 0x500>; >>>>> ti,chan-step-sampledelay = <0x0 0x0 0x0 0x0 0x0 0x0 0x0>; >>>> >>>> For a touch screen, there is not need to change in these parameter >>>> settings, so my opinion is to keep it as is. Or am I missing something? >>> I was thinking that if you are using this driver as an ADC, you may want >>> the flexibility to make these changes in the DT. I’m doing this by >>> connecting sensors to the ADC inputs. I’m not using this driver for a >>> touchscreen. >> > > ti_am335x_adc driver already supports above DT parameters and its upto > the user to adjust these parameters as required. > >> Here is a DT overlay were this gets using on the BeagleBoneBlack. >> >> https://github.com/RobertCNelson/bb.org-overlays/blob/master/src/arm/BB-ADC-00A0.dts >> >> Besides, these DT features are already implemented in the driver so it is >> just a matter of adding these entries to the am33xx.dtsi & am4372.dtsi, >> which you modified in this patch series. >> > > Touchscreen driver (ti_am335x_tsc.c) does not support above DT parameters. This patch series also modifies ti_am335x_adc.c
https://github.com/analogdevicesinc/linux/blob/master/drivers/iio/adc/ti_am335x_adc.c#L447 Regards, John > > -- > Regards > Vignesh
