On 13 October 2016 at 11:22, Pratyush Anand <pan...@redhat.com> wrote: > > > On Wednesday 12 October 2016 04:46 PM, Yao Qi wrote: >> >> On Wed, Oct 12, 2016 at 6:58 AM, Pratyush Anand <pan...@redhat.com> wrote: >>> >>> Since, arm64 can support all offset within a double word limit. >>> Therefore, >>> now support other lengths within that range as well. >> >> >> How does ptracer (like GDB) detect kernel has already supported all byte >> address select values? I suppose ptrace(NT_ARM_HW_WATCH, ) with >> len is 3 or 5 fail on current kernel but is of success after your patches >> applied. >> > > Thanks for testing these patches. > > I do not know if we can know that other than the failure of > ptrace(PTRACE_SETREGSET, .., NT_ARM_HW_WATCH, ..). I do not see any such > option in `man ptrace`. That's how I intend to implement support for this in LLDB. if (setExactWatchpoint()) return true; // watchpoint set, new kernel if (setApproxWatchpoint()) return true; // watchpoint set, old kernel return false; // watchpoints not working
seems straight-forward enough to me.