On 28.9.2016 21:34, Alan Tull wrote: > On Wed, Sep 28, 2016 at 6:41 PM, Moritz Fischer > <moritz.fisc...@ettus.com> wrote: > Hi Moritz, > >> Hi Alan, >> >> generally ok with the change. > > Cool! > >> >> On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull <at...@opensource.altera.com> >> wrote: >> >>> -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf, >>> - size_t count) >>> +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info >>> *info, >>> + const char *buf, size_t count) >> >> Doesn't this break the both socfpga and zynq if [6/12] and [7/12] are >> not part of this commit? >> i.e shouldn't 5,6 and 7 be a single commit? > > Yeah, squashing those would improve bisectability.
Improve? :-) Definitely this needs to be the part of this commit. M
