Mark Brown writes: > On Tue, Sep 27, 2016 at 03:50:42PM +0200, Wolfgang Wiedmeyer wrote: > >> When charging is disabled (e.g. by removing the USB cable) the charge >> current is not reset to zero. So if I expose the current by the >> CURRENT_NOW property, it incorrectly reports the current that was set >> when charging was enabled, although there is no charging going on >> anymore. So I felt the need to update the charge current every time the >> charger gets enabled or disabled. >> Initially, the charge current is set to zero, so I think it needs to be >> set at least at the beginning to enable charging. > > Are you sure that the register value you're looking at is the actual > charge current right now and not just the maximum that the charger will > try to use depending on the conditions (supply available, battery > state...)? It seems like you're acting as though it's the latter but > that's not what the chip is doing.
I was looking at the vendor code that was released for the Galaxy S3 and there the same register gets accessed for getting the current for the CURRENT_NOW property [1] and for setting the current [2]. So is this probably the wrong use of the CURRENT_NOW property because not the actual charge current is read but the maximum value that was set? Unfortunately, I don't have access to the datasheet and I didn't find it online so I don't know where the actual current can be accessed. Thanks, Wolfgang [1] https://code.fossencdi.org/kernel_samsung_smdk4412.git/tree/drivers/battery/max77693_charger.c#n531 [2] https://code.fossencdi.org/kernel_samsung_smdk4412.git/tree/drivers/battery/max77693_charger.c#n552 -- Website: https://fossencdi.org OpenPGP: 0F30 D1A0 2F73 F70A 6FEE 048E 5816 A24C 1075 7FC4 Key download: https://wiedmeyer.de/keys/ww.asc
signature.asc
Description: PGP signature
