On Feb 21 2007 11:00, Giuseppe Bilotta wrote: >On Wednesday 21 February 2007 02:49, Greg KH wrote: > >> /* frame pointer must be last for get_wchan */ >> -#define SAVE_CONTEXT "pushq %%rbp ; movq %%rsi,%%rbp\n\t" >> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" >> +#define SAVE_CONTEXT "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t" >> +#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t" > >No idea if this is a problem or not, but you forgot a \n after popf.
It is on the edge. RESTORE_CONTEXT will not be passed any arguments, so it is the only thing in a single line, and hence the implicit \n of the source file applies after \t. But yes, it may be dangerous. Better is an explicit \n or semicolon after popf. Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
