On Mon, Feb 19, 2007 at 06:04:45PM +0300, Oleg Nesterov wrote: > On 02/19, Jarek Poplawski wrote: > > > > On Mon, Feb 19, 2007 at 03:03:53PM +0300, Oleg Nesterov wrote: > > > On 02/19, Jarek Poplawski wrote: > > ... > > > kfree() doesn't check WORK_STRUCT_PENDING, it makes no > > > difference if it is set or not when work->func() runs. > > > > It looks like it's to be checked before kfree. > > Here, > br_add_if: ...
I meant "it's to be checked", if it's used by a program. The name: work_release seems to tell the work function could signal, when it doesn't need a structure no more. But br_if.c doesn't seem to use this infomation now, so there should be no difference after changing to "without _NAR". This change will limit some potential changes in the future, but if it's not used by anybody than the simpler api is a gain. Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
