On Tue, Feb 20, 2007 at 10:58:17AM +0000, David Howells wrote:
> Kawai, Hidehiro <[EMAIL PROTECTED]> wrote:
> Actually, I don't think the locking is that hard or that complex.
> 
>       int do_coredump(long signr, int exit_code, struct pt_regs * regs)
>       {
>               <setup vars>
> 
>               down_read(&coredump_settings_sem);
> 
>               ...
> 
>       fail:
>               up_read(&coredump_settings_sem);
>               return retval;
>       }
> 
> And:
> 
>       static ssize_t proc_coredump_omit_anon_shared_write(struct file *file,
>                                                   const char __user *buf,
>                                                   size_t count,
>                                                   loff_t *ppos)
>       {
>               <setup vars>
> 
>               down_write(&coredump_settings_sem);

If the dump has started, do we want to change this to a trylock and skip
changing the value if it is already locked?

Thanks,
Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to