On Sat, Feb 17, 2007 at 05:59:08PM -0500, Theodore Tso wrote: > On Sat, Feb 17, 2007 at 06:54:59PM +0200, Artem Bityutskiy wrote: > > diff -auNrp tmp-from/drivers/mtd/ubi/misc.h tmp-to/drivers/mtd/ubi/misc.h > > --- tmp-from/drivers/mtd/ubi/misc.h 1970-01-01 02:00:00.000000000 +0200 > > +++ tmp-to/drivers/mtd/ubi/misc.h 2007-02-17 18:07:26.000000000 +0200 > > @@ -0,0 +1,146 @@ > > +#define xquotise(s) #s > > +#define quotise(s) xquotise(s) > > Nothing in your patch series uses this, and it's identical to > stringify(). Please remove? > > > +/** > > + * rb_for_each_entry - walk an RB-tree. > > + * > > + * @rb: a pointer to type 'struct rb_node' to to use as a loop counter > > + * @pos: a pointer to RB-tree entry type to use as a loop counter > > + * @root: RB-tree's root > > + * @member: the name of the 'struct rb_node' within the RB-tree entry > > + */ > > +#define rb_for_each_entry(rb, pos, root, member)... > > Shouldn't this be added to include/linux/rbtree.h? > > > +/** > > + * strdup_len - duplicate a string with known length. > > + * > > + * @str: original string > > + * @len: the length of the string > > + */ > > +char *strdup_len(const char *str, int len); > > I'm not sure this should be polluting the kernel symbol namespace, > especially since the implementation calls ubi_assert().... > > It's not clear the assertion is all that useful, but if you must have > it, why not do the check as an inline (with the assertion normally > turned off), and then call out to kmemdup()?
Agreement to all of the above. And _please_ move all kdoc comments to the implementation files. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
